Resultcollector refactor fixed #6806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderr
added a commit
that referenced
this pull request
Dec 4, 2023
* restored resultcollector-refactor changes * fixes * todo * note * committed stashed changes: may need to be reverted * implemented new approachg * fix * fix * refined test cases * do report null values to result collectors * todo * pep8 * todos * Reapply "Compiler: refactored ResultCollector propagation and fixed bug in list comprehension gradual execution (PR #6597)" This reverts commit 211ab6d. * fix * added test * added test case * fix * more tests and fixes * added change entries * todo markers * added test case * change entries * mypy * todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #6033
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the boxAttached issue to pull requestIf this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)