Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form not handling modifiers correctly for embedded entities. #5375

Closed
LukasStordeur opened this issue Dec 12, 2023 · 1 comment
Closed

Form not handling modifiers correctly for embedded entities. #5375

LukasStordeur opened this issue Dec 12, 2023 · 1 comment
Assignees
Labels
bug Something isn't working maintanance Maintanance of the application

Comments

@LukasStordeur
Copy link
Collaborator

There is an error in how the instance form handles modifiers. The relation is rw+ so that means that the form allows to add or delete slices (this is correct). However, for the new slices it applies the edit logic. I also include a database dump here so you can get this form as well.

Link to DumpDB

image
image

@LukasStordeur LukasStordeur added bug Something isn't working maintanance Maintanance of the application labels Dec 12, 2023
@LukasStordeur LukasStordeur self-assigned this Dec 13, 2023
@LukasStordeur
Copy link
Collaborator Author

Currently, we get set the editable state of a field based on the attributeModel. Each field only cares about the current value, original and default value, and what kind of modifier is present in the attributeModel. This means that an input field isn't aware if it's part of a dict or not, or if it's a new item from a dict or not that should allow editing the values.

To add awareness is possible, but would require a fair amount of effort and changes. Currently not the highest on the priority list, but needs to be resolved either way.

inmantaci pushed a commit that referenced this issue Feb 20, 2024
…ity when the form is in edit-mode (Issue #5375, PR #5546)

# Description

Enabling the possibility to add new nested entities that are within embedded entities.

closes *#5375*

https://github.com/inmanta/web-console/assets/44098050/d8f2015e-be7e-4737-9a5c-c661f8f07e76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintanance Maintanance of the application
Projects
None yet
Development

No branches or pull requests

1 participant