Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In targeting docs, note which properties are provided by jquery.dfp.js #19

Closed
benlk opened this issue Jul 27, 2016 · 3 comments
Closed

Comments

@benlk
Copy link
Collaborator

benlk commented Jul 27, 2016

https://dfw.readthedocs.io/en/latest/Targeting/

inURL, URLIs, Query, and Domain are provided by jQuery.dfp.js, not by our plugin. They'll be available all the same.

This is more of a developer note than a user-facing note, so maybe it should go in the part of the widget where we create the other targeting parameters.

@benlk
Copy link
Collaborator Author

benlk commented Aug 3, 2016

No, this is definitely user-facing if they're setting up targeting, and deserves user-facing docs.

@benlk
Copy link
Collaborator Author

benlk commented Aug 3, 2016

As part of this, improve the targeting docs: https://github.com/INN/DoubleClick-for-WordPress/blob/master/docs/Targeting.md

It should explain how to target ads to a specific category.

@benlk
Copy link
Collaborator Author

benlk commented Aug 23, 2016

This is covered in the WIP lecture series notes that Jack and I have been working on; I'll close this.

@benlk benlk closed this as completed Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant