Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust HorizontalPillList #1199

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

anafilipadealmeida
Copy link
Contributor

Description

  • Wrap <Pills>in the <HorizontalPillList> in function table
  • Use shared tooltip in <HorizontalPillList> and adjust the styles
Screenshot 2024-02-28 at 22 26 42 Screenshot 2024-02-28 at 22 23 13

Motivation

Note: John designed a new way of displaying multiple pills that doesn't involve a tooltip. However, since it affects the table rows alignment and our tables are not using the same components/styles, we'll only implement it as part of the events table project.

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

Copy link

linear bot commented Feb 28, 2024

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Feb 28, 2024 10:39pm

@anafilipadealmeida anafilipadealmeida merged commit 8300946 into main Feb 29, 2024
13 checks passed
@anafilipadealmeida anafilipadealmeida deleted the ana/inn-2805-refactor-horizontalpilllist branch February 29, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants