Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing running state in Dev Server UI #1207

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix missing running state in Dev Server UI #1207

merged 2 commits into from
Mar 1, 2024

Conversation

goodoldneon
Copy link
Contributor

Description

  • Make functionRun resolver use the history store
  • Delete FunctionRun.name in GraphQL since it doesn't make sense (names are on functions, not runs)
  • Fix history store missing run output

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

@vercel Vercel
Copy link

vercel bot commented Mar 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 1:43am

@goodoldneon goodoldneon merged commit 8829942 into main Mar 1, 2024
12 checks passed
@goodoldneon goodoldneon deleted the use-history-store-for-run branch March 1, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhb tonyhb tonyhb approved these changes

@djfarrelly djfarrelly Awaiting requested review from djfarrelly djfarrelly is a code owner

@darwin67 darwin67 Awaiting requested review from darwin67 darwin67 is a code owner

@jpwilliams jpwilliams Awaiting requested review from jpwilliams jpwilliams is a code owner

@IGassmann IGassmann Awaiting requested review from IGassmann

@anafilipadealmeida anafilipadealmeida Awaiting requested review from anafilipadealmeida anafilipadealmeida is a code owner

Assignees
No one assigned
Labels
area/dev-server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@goodoldneon @tonyhb