Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI crash due to spare events array #1214

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

goodoldneon
Copy link
Contributor

Description

Fix a Dev Server stream UI crash when GraphQL returns a sparse events array (i.e. a null in the array). This happens for crons, since they don't have an event. I'm not sure if there are other ways the event could be nil

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
ui ⬜️ Ignored (Inspect) Mar 5, 2024 4:16pm

@goodoldneon goodoldneon merged commit 3cf0871 into main Mar 5, 2024
12 checks passed
@goodoldneon goodoldneon deleted the fix-crash-due-to-null-event branch March 5, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants