Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toast to Replay #1215

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Add toast to Replay #1215

merged 3 commits into from
Mar 5, 2024

Conversation

anafilipadealmeida
Copy link
Contributor

@anafilipadealmeida anafilipadealmeida commented Mar 5, 2024 •
edited
Loading

Description

  • Add toast to replay (replicated the same logic used in other parts with the same method, works for now)
  • Move toast to the bottom of the screen, as the top right corner is too busy and difficult to read (it also matches Cloud)
    Screenshot 2024-03-05 at 17 26 52

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 5:49pm

@anafilipadealmeida anafilipadealmeida merged commit b1e31b3 into main Mar 5, 2024
12 checks passed
@anafilipadealmeida anafilipadealmeida deleted the ana/add-toast branch March 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodoldneon goodoldneon goodoldneon approved these changes

@IGassmann IGassmann Awaiting requested review from IGassmann

@djfarrelly djfarrelly Awaiting requested review from djfarrelly djfarrelly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anafilipadealmeida @goodoldneon