-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INN-2874: Incorporate tracer into codebase for user traces #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
9769906
to
311f143
Compare
jpwilliams
reviewed
Mar 19, 2024
this is only for sending purposes to the otel collector. and changes on the otel collector size is also necessary in order for it to accept the potentially larger payloads.
This simplifies the model and we don't need to track the tracers everywhere.
7e32a82
to
8df261f
Compare
8df261f
to
093cfbf
Compare
jpwilliams
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces a singleton tracer that can be used for user traces.
We want to keep the default global singleton for system traces in the future, so we don't cause any conflicts between the two.
The change also add basic instrumentation from event ingestion to step runs for now.
The following are not added and will be follow ups.
Motivation
Type of change (choose one)
Checklist
Check our Pull Request Guidelines