Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INN-2874: Incorporate tracer into codebase for user traces #1237

Merged
merged 26 commits into from
Mar 20, 2024

Conversation

darwin67
Copy link
Collaborator

@darwin67 darwin67 commented Mar 15, 2024

Description

This change introduces a singleton tracer that can be used for user traces.
We want to keep the default global singleton for system traces in the future, so we don't cause any conflicts between the two.

The change also add basic instrumentation from event ingestion to step runs for now.
The following are not added and will be follow ups.

  • invoke
  • fan out
  • tracestate forwarding to SDKs

Motivation

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

Copy link

linear bot commented Mar 15, 2024

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 5:51pm

@darwin67 darwin67 force-pushed the darwin/INN-2874 branch 4 times, most recently from 9769906 to 311f143 Compare March 18, 2024 22:09
@darwin67 darwin67 marked this pull request as ready for review March 18, 2024 22:10
cmd/commands/dev.go Outdated Show resolved Hide resolved
pkg/consts/otel.go Show resolved Hide resolved
pkg/consts/otel.go Outdated Show resolved Hide resolved
@darwin67 darwin67 merged commit fc9dcf3 into main Mar 20, 2024
12 checks passed
@darwin67 darwin67 deleted the darwin/INN-2874 branch March 20, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants