Fix data fetching issue on Vercel integration page #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Requests should be paused if there is no URL * Loading and data should be updated on failed responses * All loading states should be considered
djfarrelly
requested review from
anafilipadealmeida and
goodoldneon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
djfarrelly
commented
Mar 19, 2024
| @@ -72,7 +73,7 @@ export function useVercelIntegration(): { | |||
|
|
|||
| return { | |||
| data: vercelIntegration, | |||
| fetching: fetching || isLoadingSavedProjects, | |||
| fetching: isLoadingEnvironments || isLoadingAllProjects || isLoadingSavedProjects, | |||
There was a problem hiding this comment.
I should have been considering all loading states, but wasn't before
anafilipadealmeida
approved these changes
Mar 19, 2024
djfarrelly
commented
Mar 19, 2024
| }: { | ||
| url: string | URL | null; | ||
| method: string; | ||
| pause: boolean; |
There was a problem hiding this comment.
Added this feature similar to URQL to prevent the URL from being hit dynamically. The url check on line 28 should have done this, but it might not have updated for some reason. Leaving in for now.
djfarrelly
commented
Mar 19, 2024
Comment on lines
+31
to
+41
|
|
||
| setIsLoading(true); | ||
| const response = await fetch(url, { | ||
| method, | ||
| headers: { | ||
| Authorization: `Bearer ${sessionToken}`, | ||
| }, | ||
| }); | ||
| if (!response.ok || response.status >= 400) { | ||
| setData(null); | ||
| setIsLoading(false); |
There was a problem hiding this comment.
Errors would previously just should stuck as loading before this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hotfix for data not loading on Vercel integration page.
Motivation
Bug reported after #1236 was merged
Type of change (choose one)
Checklist
Check our Pull Request Guidelines