Display event keys created via integration #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djfarrelly
requested review from
anafilipadealmeida and
goodoldneon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <DeleteKeyModal | ||
| keyID={keyID} | ||
| isOpen={isDeleteKeyModalVisible} | ||
| onClose={() => setIsDeleteKeyModalVisible(false)} | ||
| description={ | ||
| isIntegration | ||
| ? 'Warning: This key was created via integration. Please confirm that you are no longer using it before deleting.' |
There was a problem hiding this comment.
This being a warning it might make sense to use the <Alert> component in the future, but the best would be to make the AlertModal more composable, so it can be for later
There was a problem hiding this comment.
Good idea! I was thinking about doing this, but avoided the refactor as description was a string type. I think all of our confirmation modals and dialogs could use some cleanup and a new design with options.
anafilipadealmeida
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display all event keys, including those created via integration. Adds a warning to the delete key modal and a label to the event key to denote how the key was created.
Motivation
Event Keys created via the Vercel integration were not shown in the UI, preventing users from verifying the installation and validity of keys set as environment variables in their Vercel project.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines