Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INN-2888 INN-2876 INN-2887 Trace fan-out, invoke, propagation #1249

Merged
merged 27 commits into from
Mar 28, 2024
Merged

INN-2888 INN-2876 INN-2887 Trace fan-out, invoke, propagation #1249

merged 27 commits into from
Mar 28, 2024

Conversation

jpwilliams
Copy link
Member

Description

Adds propagation for fan-out and invoke and intentionally includes no tracking of any step concepts; only executions.

image

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Related

Check our Pull Request Guidelines

@jpwilliams
Ensure trace state is passed to SDKs during requests
fe51878
@jpwilliams
When sending invocation events, pass trace state in metadata
1748118
@jpwilliams
Move event ingestion trace up to provide proper linking
ee5cd13
@jpwilliams
Set queue.Item.Metadata to be map[string]any
dfe9d0b
@jpwilliams
Mark span as initial discovery step when scheduling
e93869d
@jpwilliams
Differentiate step spans from execution (attempt) spans
182d5bf
@jpwilliams
Attempt to extract span from queue item as well as run metadata
8b6ef6e
@jpwilliams
Set span names according to attempt numbers or function resolution
af5dfcf
@jpwilliams
Add parent span contexts for each step to contain individual attempts
20df548 
Very repeated code - will clean.
@jpwilliams
Add TODO notes for some step op handlers
c3d492b
@jpwilliams
Set step error status when an attempt fails
62208f5
@jpwilliams
progress dump
a4dab64
@jpwilliams
Use IgnoredSpanProcessor in all trace providers
cad11b2
@jpwilliams
Remove tracking creation of a step; only track attempts
b5211d9
@jpwilliams
Do not show discovery steps
219e386
@jpwilliams jpwilliams self-assigned this Mar 25, 2024
@linear Linear
Copy link

linear bot commented Mar 25, 2024

INN-2888 When invoking, create child spans from the step

INN-2876 When executing a function with an HTTP request, send the span ID

INN-2887 Link fan-out event sends with step parent and trace ID

@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 5:35pm

darwin67
darwin67 requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@darwin67 darwin67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall look solid with some change requests.

pkg/api/api.go Show resolved Hide resolved
pkg/execution/executor/executor.go Show resolved Hide resolved
pkg/consts/otel.go Show resolved Hide resolved
pkg/execution/executor/executor.go Outdated Show resolved Hide resolved
pkg/execution/executor/executor.go Outdated Show resolved Hide resolved
pkg/telemetry/tracing.go Outdated Show resolved Hide resolved
darwin67
darwin67 reviewed Mar 27, 2024
View reviewed changes
pkg/telemetry/tracing.go Outdated Show resolved Hide resolved
darwin67
darwin67 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@darwin67 darwin67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. Added some additional nice to have notes, but otherwise looks good.

pkg/execution/state/driver_response.go Outdated Show resolved Hide resolved
pkg/telemetry/tracing.go Outdated Show resolved Hide resolved
pkg/telemetry/tracing.go Outdated Show resolved Hide resolved
@darwin67 darwin67 merged commit 0df4f72 into main Mar 28, 2024
12 checks passed
@darwin67 darwin67 deleted the jack/trace-propagation branch March 28, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darwin67 darwin67 darwin67 approved these changes

@tonyhb tonyhb Awaiting requested review from tonyhb tonyhb is a code owner

@djfarrelly djfarrelly Awaiting requested review from djfarrelly djfarrelly is a code owner

@goodoldneon goodoldneon Awaiting requested review from goodoldneon goodoldneon is a code owner

Assignees

@jpwilliams jpwilliams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpwilliams @darwin67