Fix Dev Server polling and discovery #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows better matching to know when to avoid polling
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jpwilliams
commented
Apr 12, 2024
| @@ -71,7 +73,7 @@ func Autodiscover(ctx context.Context) map[string]struct{} { | |||
| for _, path := range Paths { | |||
| // These requests _should_ be fast as we know a port is open, | |||
| // so we do these sequentially. | |||
| url := fmt.Sprintf("http://127.0.0.1:%d%s", port, path) | |||
| url := util.NormalizeAppURL(fmt.Sprintf("http://127.0.0.1:%d%s", port, path), false) | |||
There was a problem hiding this comment.
This fixes an issue where, even if polling was disabled, an app would be discovered at this URL and pinged, as this raw URL was different to the normalized URL within the existing app.
djfarrelly
approved these changes
Apr 23, 2024
jpwilliams
requested review from
tonyhb,
darwin67 and
goodoldneon
as code owners
darwin67
approved these changes
Apr 24, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Polling and discovery in the Dev Server can be really verbose. Many frameworks, by default, will log all incoming HTTP requests, resulting in a huge spam of logs while the Dev Server is running. This makes debugging harder and it just looks messy.
In addition, the
--no-discoveryand--no-pollflags can unintentionally remove features, meaning users cannot achieve a balance of automatically adding the apps they want without spamming.Description
This PR aims to clear up the confusion of these flags the functionality it controls.
In this area, there are a few scenarios to cover. This is the behaviour we're aiming for, with⚠️ marks representing that this is not the current functionality and will be fixed in this PR.
--no-poll--no-discovery--no-poll --no-discovery--sdk-url--no-poll --sdk-url--no-discovery --sdk-url--no-poll --no-discovery --sdk-urlFrom this, we see an incompatibility with
--no-polland other options. To fix this, if--no-pollis specified:With the latter, an erroring app means that either it did exist or a user manually added it via the flag or UI. If this is the case, should we poll until we find it?
UI
The UI also always shows that we are "Auto-detecting apps..." and doesn't actually check whether this feature is enabled or not.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines