Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test for batch invoke #1281

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

darwin67
Copy link
Collaborator

@darwin67 darwin67 commented Apr 16, 2024

Description

Follow similar test pattern for normal batch operation.
Testing both when batch is full and when timeout, instead of just timeout, which can lead to timing issues.

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
ui ⬜️ Ignored (Inspect) Apr 16, 2024 8:14pm

@darwin67 darwin67 merged commit 39c54a7 into main Apr 17, 2024
12 checks passed
@darwin67 darwin67 deleted the darwin/fix-flaky-batch-invoke branch April 17, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants