Fix function active/archived tab switching #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodoldneon
requested review from
anafilipadealmeida and
djfarrelly
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tonyhb
previously requested changes
Apr 17, 2024
...shboard/src/app/(organization-active)/(dashboard)/env/[environmentSlug]/functions/useRows.ts
Outdated
Show resolved
Hide resolved
…v/[environmentSlug]/functions/useRows.ts Co-authored-by: Tony Holdstock-Brown <tony@inngest.com>
djfarrelly
approved these changes
Apr 17, 2024
| return; | ||
| } | ||
|
|
||
| if (functionsRes.data.page.page > functionsData.lastPage) { |
There was a problem hiding this comment.
How does this know to setFunctionsData on only archived vs. not archived?
There was a problem hiding this comment.
The data is cleared out when archived changes:
https://github.com/inngest/inngest/blob/main/ui/apps/dashboard/src/app/(organization-active)/(dashboard)/env/%5BenvironmentSlug%5D/functions/useRows.ts#L33
This whole hook needs to be refactored. It's probably the worst code I've written here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix stale data when switching between active and archived functions
Type of change (choose one)
Checklist
Check our Pull Request Guidelines