Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure batching and debounce are recorded correctly #1285

Merged
merged 4 commits into from
Apr 19, 2024
Merged

make sure batching and debounce are recorded correctly #1285

merged 4 commits into from
Apr 19, 2024

Conversation

darwin67
Copy link
Collaborator

@darwin67 darwin67 commented Apr 17, 2024 •
edited
Loading

Description

Make sure to record batching and debounce since those are not event ingestion triggers

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

@linear Linear
Copy link

linear bot commented Apr 17, 2024

INN-2912 Start spec on API and possible query patterns for Clickhouse

@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 0:01am

@darwin67 darwin67 changed the title change condition for batch annotation make sure batching and debounce are recorded correctly Apr 18, 2024
@darwin67 darwin67 force-pushed the darwin/INN-2912 branch 5 times, most recently from 59da88e to 4a5af99 Compare April 18, 2024 21:45
@darwin67 darwin67 merged commit 4b4147a into main Apr 19, 2024
12 checks passed
@darwin67 darwin67 deleted the darwin/INN-2912 branch April 19, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhb tonyhb tonyhb approved these changes

@djfarrelly djfarrelly Awaiting requested review from djfarrelly djfarrelly is a code owner

@goodoldneon goodoldneon Awaiting requested review from goodoldneon goodoldneon is a code owner

@jpwilliams jpwilliams Awaiting requested review from jpwilliams jpwilliams is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darwin67 @tonyhb