Add new runs page #1288
Merged
Add new runs page #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anafilipadealmeida
requested review from
goodoldneon and
djfarrelly
as code owners
goodoldneon
reviewed
Apr 18, 2024
| @@ -54,6 +57,18 @@ export default function FunctionLayout({ children, params }: FunctionLayoutProps | |||
| }, | |||
| ]; | |||
|
|
|||
| if (isNewRunsEnabled.value) { | |||
| navLinks.push({ | |||
| href: `/env/${params.environmentSlug}/functions/${params.slug}/runs`, | |||
There was a problem hiding this comment.
It's nice that we can use /runs right away since the old page uses /logs 😆
goodoldneon
reviewed
Apr 18, 2024
.../(organization-active)/(dashboard)/env/[environmentSlug]/functions/[slug]/runs/RunsTable.tsx
Outdated
Show resolved
Hide resolved
goodoldneon
reviewed
Apr 18, 2024
goodoldneon
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of this work is temporary, I'm marking most of that in the code with the
TODOnotation.Motivation
This is the beginning of the new runs work. I needed a very basic table to now build the filters and store them in the search params.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines