INN 2962 Add status filter to runs #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anafilipadealmeida
requested review from
goodoldneon and
djfarrelly
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <main className="min-h-0 overflow-y-auto bg-white"> | ||
| <div className="flex justify-between gap-2 bg-slate-50 px-8 py-2"> | ||
| <StatusFilter | ||
| selectedStatuses={filteredStatus ? (filteredStatus as FunctionRunStatus[]) : []} |
There was a problem hiding this comment.
Is there a better way to do this validation @goodoldneon ?
goodoldneon
reviewed
Apr 22, 2024
.../(organization-active)/(dashboard)/env/[environmentSlug]/functions/[slug]/runs/RunsTable.tsx
Show resolved
Hide resolved
goodoldneon
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
This is part of the new runs work.
Some of this work is temporary, as the main focus at the moment is to get the layouts and state right.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines