Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flat side support for Badge #1301

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Add flat side support for Badge #1301

merged 1 commit into from
Apr 26, 2024

Conversation

goodoldneon
Copy link
Contributor

Description

Add a new flatSide prop for the Badge component. This is necessary to fulfill the "split badge" design in the new run details:
image

Testing

image image

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 2:19pm

@goodoldneon goodoldneon merged commit 993f11d into main Apr 26, 2024
13 checks passed
@goodoldneon goodoldneon deleted the Badge-flat-side branch April 26, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants