Allow for increased steps based off of identifiers #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyhb
requested review from
djfarrelly,
darwin67,
goodoldneon and
jpwilliams
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This allows customisation of step limits dependent on various factors in the identifier. Note that defaults do not change
tonyhb
force-pushed
the
feat/expanded-steps
branch
from
ef56db2
to
cc11ac9
Compare
darwin67
reviewed
Apr 25, 2024
| @@ -168,11 +168,8 @@ func WithLifecycleListeners(l ...execution.LifecycleListener) ExecutorOpt { | |||
| } | |||
| } | |||
|
|
|||
| func WithStepLimits(limit uint) ExecutorOpt { | |||
| func WithStepLimits(limit func(id state.Identifier) int) ExecutorOpt { | |||
There was a problem hiding this comment.
shouldn't this be uint as well if the previous was an uint?
There was a problem hiding this comment.
its mainly for types, so that we don't need to continue to typecast everywhere. we actively check for <= 0 in the validator so it's okay being an int, and is (i suppose) an easier type to work with.
darwin67
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows customisation of step limits dependent on various factors in the identifier. Note that defaults do not change
Type of change (choose one)
Checklist
Check our Pull Request Guidelines