Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INN 2940 create select shared component #1311

Merged
merged 14 commits into from
Apr 30, 2024
Merged

INN 2940 create select shared component #1311

merged 14 commits into from
Apr 30, 2024

Conversation

anafilipadealmeida
Copy link
Contributor

@anafilipadealmeida anafilipadealmeida commented Apr 29, 2024 •
edited
Loading

Description

  • Replace status icons by new design in runs list
    The old run icons are marked as deprecated, as we ca only delete them once we replace the current logs page
  • Create Select component to be used in status filter
    This is optimized only for multi select, will support the single select option when building the time filters
Screen.Recording.2024-04-29.at.22.15.42.mov

Motivation

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

@linear Linear
Copy link

linear bot commented Apr 29, 2024

INN-2940 Create Select shared component

@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 1:32pm

@anafilipadealmeida anafilipadealmeida changed the title Ana/inn 2940 create select shared component INN 2940 create select shared component Apr 29, 2024
@anafilipadealmeida anafilipadealmeida marked this pull request as ready for review April 29, 2024 22:19
djfarrelly
djfarrelly approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@djfarrelly djfarrelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. It's hard to tell without running this locally, but some of the spacing feels a little off proportion wise in comparison to Figma, specifically vertical and horizontal spacing of items.

Figma Code
image image

@anafilipadealmeida
Copy link
Contributor Author

These are not the final styles, as I'm doing adjustments while tweaking the Select for the Time Filters as well. But I changed the paddings a little, so nobody panics 😂
Screenshot 2024-04-30 at 14 22 12

@anafilipadealmeida anafilipadealmeida merged commit 3b3e685 into main Apr 30, 2024
13 checks passed
@anafilipadealmeida anafilipadealmeida deleted the ana/inn-2940-create-select-shared-component branch April 30, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodoldneon goodoldneon goodoldneon left review comments

@djfarrelly djfarrelly djfarrelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anafilipadealmeida @djfarrelly @goodoldneon