Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time field filter #1313

Merged
merged 7 commits into from
May 1, 2024
Merged

Add time field filter #1313

merged 7 commits into from
May 1, 2024

Conversation

anafilipadealmeida
Copy link
Contributor

@anafilipadealmeida anafilipadealmeida commented Apr 30, 2024 •
edited

Description

  • Add single select variation
  • Add timefield filter
  • Add Select wrapper

Screenshot:
Screenshot 2024-04-30 at 23 48 40

Recording:

Screen.Recording.2024-04-30.at.23.52.17.mov

Next PR:

  • Relative time select
  • Select Transitions and width to avoid changes to selects.

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

@linear Linear
Copy link

linear bot commented Apr 30, 2024

INN-2964 Add time filter to runs

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 10:50pm

@anafilipadealmeida anafilipadealmeida marked this pull request as ready for review April 30, 2024 22:51
@anafilipadealmeida anafilipadealmeida changed the title Add time filters Add time field filter Apr 30, 2024
@anafilipadealmeida anafilipadealmeida merged commit f57d0bb into main May 1, 2024
13 checks passed
@anafilipadealmeida anafilipadealmeida deleted the ana/inn-2964-add-time-filter-to-runs branch May 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djfarrelly djfarrelly djfarrelly approved these changes

@goodoldneon goodoldneon Awaiting requested review from goodoldneon goodoldneon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anafilipadealmeida @djfarrelly