Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INN-3003: Fix consistent sort order for apps #1324

Conversation

djfarrelly
Copy link
Member

Description

The API resolver does not ensure consistent ordering. This ensures there is consistent ordering by last synced at date in the UI.

Motivation

It is jarring to see apps shuffle and re-order at random when sitting on this page. This should never happen.

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

Copy link

linear bot commented May 6, 2024

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 10:22pm

@djfarrelly djfarrelly merged commit e572083 into main May 6, 2024
7 checks passed
@djfarrelly djfarrelly deleted the dan/inn-3003-apps-do-not-retain-order-in-ui-on-periodic-refresh branch May 6, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants