Add queue peek size control and additional metrics #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
darwin67
commented
May 7, 2024
| func IncrQueuePeekedCounter(ctx context.Context, incr int64, opts CounterOpt) { | ||
| recordCounterMetric(ctx, incr, counterOpt{ | ||
| Name: opts.PkgName, | ||
| MetricName: "queue_peeked_total", |
There was a problem hiding this comment.
this is the new metric added.
darwin67
commented
May 7, 2024
darwin67
force-pushed
the
darwin/reduce-peek-size
branch
from
74e65f1
to
4654000
Compare
darwin67
force-pushed
the
darwin/reduce-peek-size
branch
from
669f1ee
to
3838377
Compare
darwin67
changed the title
darwin67
requested review from
djfarrelly,
goodoldneon and
jpwilliams
as code owners
these don't need to be embedded and should be globally accessible for instrumentation purposes
tonyhb
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add attribute to control the queue peek size.
Also add additional metrics for instrumenting queue performance, and reorganize some of the existing counters into
telemetry.scopeandmeterhas been removed from the queue attributes. these should be accessible globally without being embedded.Type of change (choose one)
Checklist
Check our Pull Request Guidelines