Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store trace spans into sqlite #1328

Merged
merged 3 commits into from
May 9, 2024
Merged

Store trace spans into sqlite #1328

merged 3 commits into from
May 9, 2024

Conversation

darwin67
Copy link
Collaborator

@darwin67 darwin67 commented May 8, 2024

Description

Store the received spans into sqlite.
Attempts to dedup and aggregate the data as much as possible before storing them, which reduce the footprint of memory being used.

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

attempts to dedup and aggregate the data as much as possible before
storing them in the database.
this should reduce the memory footprint for sqlite, and also be less
work for aggregation when querying for the data
Copy link

linear bot commented May 8, 2024

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 2:15am

pkg/devserver/span.go Dismissed Show dismissed Hide dismissed
pkg/devserver/span.go Dismissed Show dismissed Hide dismissed
@darwin67 darwin67 marked this pull request as ready for review May 8, 2024 02:18
Copy link
Contributor

@tonyhb tonyhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@darwin67 darwin67 merged commit 6907e72 into main May 9, 2024
12 checks passed
@darwin67 darwin67 deleted the darwin/INN-2975-storage branch May 9, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants