Add lease denylists #1334
Merged
Add lease denylists #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyhb
requested review from
djfarrelly,
darwin67,
goodoldneon,
jpwilliams and
BrunoScheufler
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This commit introduces lease denylists for queue items. When attempting to lease queue items, we pull a chunk of work from the queue in FIFO order as a list of queue items. We iterate through this list, and attempt to lease the queue item. The queue item may fail to lease because of concurrency keys or throttling keys. In this case, we may still keep iterating on the list to attempt to process *other* items with *different* concurrency keys. We add these failed keys to a denylist, and never attempt to lease those queue items within the same iterations. This keeps FIFO order and prevents queue churn.
tonyhb
force-pushed
the
feature/lease-denylists
branch
from
8c7c584
to
73f8bfc
Compare
darwin67
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces lease denylists for queue items. When attempting
to lease queue items, we pull a chunk of work from the queue in FIFO
order as a list of queue items. We iterate through this list, and
attempt to lease the queue item.
The queue item may fail to lease because of concurrency keys or
throttling keys. In this case, we may still keep iterating on the list
to attempt to process other items with different concurrency keys.
We add these failed keys to a denylist, and never attempt to lease those
queue items within the same iterations. This keeps FIFO order and
prevents queue churn.
Note that denylists are temporary and only exist per executor for the
function currently being peeked.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines