Move async gauge instrumentation as part of initialization #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darwin67
requested review from
tonyhb,
djfarrelly,
goodoldneon,
jpwilliams and
BrunoScheufler
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
darwin67
changed the title
tonyhb
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current otel gauge APIs only allow observables, and not sync instrumentation.
Move them to queue initialization instead so we don't attempt to register the callbacks multiple times. Which also contributes to memory growth.
Ref:
https://pkg.go.dev/go.opentelemetry.io/otel/metric#hdr-Measurements
Also add an internal registry to make sure metrics are not registered multiple times.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines