Add runID to step.invoke() when the run is scheduled
#1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darwin67
requested review from
tonyhb,
djfarrelly,
goodoldneon,
jpwilliams and
BrunoScheufler
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jpwilliams
approved these changes
May 15, 2024
pkg/event/event.go
Outdated
Comment on lines
276
to
285
| InvokeFnID: opts.FnID, | ||
| InvokeCorrelationId: correlationID, | ||
| InvokeSpanID: spanID, | ||
| InvokeTimestamp: opts.SpanTimestamp, | ||
| InvokeExpiresAt: opts.ExpiresAt, | ||
| InvokeGroupID: opts.GroupID, | ||
| InvokeDisplayName: opts.DisplayName, | ||
| SourceAppID: opts.SourceAppID, | ||
| SourceFnID: opts.SourceFnID, | ||
| SourceFnVersion: opts.SourceFnVersion, |
There was a problem hiding this comment.
Makes perfect sense, though it's a shame we have to push so much data into the event, as it's visible to users and has mostly a tonne of concepts they don't otherwise have access to.
8 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
darwin67
force-pushed
the
darwin/INN-3034
branch
2 times, most recently
from
18bdf06
to
213dc81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Annotate the
step.invokespan with the target runID, so it can be used as reference when showing the trace.This mainly helps with in-process runs where the invoke target might not have finished yet.
This PR also tweaks the wait virtual span to make sure it's reconstruction works as expected.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines