Built arrow from source in DEV image (#32)

innobi · Feb 27, 2022 · 575a0f9 · 575a0f9
1 parent efb9755
commit 575a0f9
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 11 deletions.
diff --git a/ci/docker/hyperarrow-dev.dockerfile b/ci/docker/hyperarrow-dev.dockerfile
@@ -1,20 +1,22 @@
 FROM debian
 
 RUN apt update
+# python and wget are for the arrow install
+# we should decouple that dependency in the future
 RUN apt-get install -y \
     build-essential \
     clang-format \
     cmake \
     libboost-system-dev \
     gdb \
-    git
+    git \
+    python3-pip \
+    wget
 
-# https://arrow.apache.org/install/
-RUN apt install -y -V ca-certificates lsb-release wget
-RUN wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
-RUN apt install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
-RUN apt update
-RUN apt install -y -V libarrow-dev # For C++
+ARG arrow=6.0.1
+ARG buildType='Debug'
+COPY ci/scripts/install_arrow.sh /hyperarrow/ci/scripts/
+RUN /hyperarrow/ci/scripts/install_arrow.sh ${arrow} ${buildType} /usr/local
 
 RUN apt-get install -y zip
 COPY ci/scripts/get_tableau_libs.sh /hyperarrow/ci/scripts/

diff --git a/ci/docker/python-wheel-manylinux-201x.dockerfile b/ci/docker/python-wheel-manylinux-201x.dockerfile
@@ -36,6 +36,7 @@ ENV PATH="$VIRTUAL_ENV/bin:$PATH"
 
 # Install arrow
 ARG arrow=6.0.1
+ARG buildType='Release'
 COPY ci/scripts/install_arrow.sh hyperarrow/ci/scripts/
 RUN /hyperarrow/ci/scripts/install_arrow.sh ${arrow} /usr/local
 

diff --git a/ci/scripts/install_arrow.sh b/ci/scripts/install_arrow.sh
@@ -19,23 +19,25 @@
 
 set -e
 
-if [ "$#" -ne 2 ]; then
-  echo "Usage: $0 <version> <prefix>"
+if [ "$#" -ne 3 ]; then
+  echo "Usage: $0 <version> <buildType> <prefix>"
   exit 1
 fi
 
 version=$1
-prefix=$2
+buildType=$2
+prefix=$3
 url="https://github.com/apache/arrow/archive/refs/tags/apache-arrow-${version}.tar.gz"
 
 mkdir /tmp/arrow
 wget -q ${url} -O - | tar -xzf - --directory /tmp/arrow --strip-components=1
-python -m pip install -r /tmp/arrow/python/requirements-build.txt
+python3 -m pip install -r /tmp/arrow/python/requirements-build.txt
 
 mkdir /tmp/arrow/cpp/build
 pushd /tmp/arrow/cpp/build
 
 cmake -DCMAKE_INSTALL_PREFIX=${prefix} \
+      -DCMAKE_BUILD_TYPE=${buildType} \
       -DARROW_PYTHON=ON \
       -DARROW_COMPUTE=ON \
       ..