Small fix for some ZSH prompt configurations #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kofrezo
approved these changes
May 16, 2019
There was a problem hiding this comment.
I am fine with disabling precmd_functions for ZSH as a bash user. I don't know if any ZSH user might rely on having precmd_functions executed for e.g. displaying exit code of last command or similiar behaviour and if this would reduce ZSH support to level people cannot use it properly.
|
Well this is mostly about exporting the PROMPT or PS1 variables and some themes/users are preferring to do it on pre* scope. Even if we're decreasing the functionality, it's for a good cause, otherwise polysh will never show the server ready for some users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zsh has precmd_functions array, which is one way to set up your prompt. Polysh is failing to provide a ready prompt if we don't unset it. preexec_functions and other similar ones might also be needed to unset but I didn't test since I don't use them.
Also reverted sorting of changelog to newest-first with some sed-magic.