Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for remaining block types #25

Closed
7 tasks done
johndgiese opened this issue May 9, 2022 · 1 comment
Closed
7 tasks done

Implement support for remaining block types #25

johndgiese opened this issue May 9, 2022 · 1 comment
Assignees
Milestone

Comments

@johndgiese
Copy link
Contributor

johndgiese commented May 9, 2022

  • Review the blocks code here https://github.com/innolitics/n2y/blob/main/n2y/blocks.py#L457-L491
  • Update the README table to add any relevant notes for the various block types
  • Every block type should be in the table
  • Only add information that is not obvious; e.g., if an paragraph block just makes a paragraph in markdown, we don't need to add any comment about it.
  • For blocks that haven't yet been implemented, write out how you think they should work in the readme table; e.g., the Pdf block can download the PDF to the "media root" and add a link in the GitHub to the downloaded PDF file.
  • Assign a PR to @bimbashrestha for him to review. The PR should ONLY contain changes to the README at this point
  • Once Bimba approves the direction, implement the proposed changes.
@johndgiese johndgiese changed the title Add support for the "link_to_page" block type Implement support for remaining block types Aug 22, 2022
@johndgiese johndgiese added this to the Current milestone Aug 25, 2022
@sHermanGriffiths
Copy link
Contributor

Addressed with PR #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants