-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 4.2 update #311
Merged
Rails 4.2 update #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are still red. We should keep an eye on |
@mjansing Is |
Try running with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should document activities to the next ruby on rails major release (v.4.2.0). The rails-4.2-branch in currently on v4.2.0.rc2. There are still issues and some failing tests.
Known Issues
Model.reflections()
-calls needs to be updated. See Rails 4.2: Model.reflections now uses strings rather than symbols as keys rails/rails#16928extend ActiveModel::Naming
in UserSession-Model after Rails 4.2 : ActionView::Template::Error (undefined method `model_name' for #<UserSession: no credentials provided>) binarylogic/authlogic#432 was fixed