Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: General fixes #312

Closed
4 tasks
aditya-kumawat opened this issue Aug 28, 2020 · 1 comment
Closed
4 tasks

Table: General fixes #312

aditya-kumawat opened this issue Aug 28, 2020 · 1 comment

Comments

@aditya-kumawat
Copy link
Contributor

aditya-kumawat commented Aug 28, 2020

Description

  • GridCell overflow: 'hidden' not required.
  • Extra space before/after Table Body Rows(need to reproduce).
  • Table: support for default page number, totalRecords(not sure yet).
  • Table: update default minWidth of GridCell.

Steps to reproduce

Clear steps describing how to reproduce the issue.

Expected result

What should happen?

Actual result

What happened.

@ypahalajani
Copy link

ypahalajani commented Aug 29, 2020

@aditya-kumawat @satyamyadav

Also, when I am using external pagination by setting withPagination prop to false, I get type error that the prop paginationType is a mandatory prop.

I am not sure whether TS has support to make certain props mandatory based on other prop's value.
But, just in case, this support is not there is TS, I think we can make this prop (paginationType) optional and set the default value as 'basic' or whatever the team decides.

What do you guys think?

P.S. I am using @innovaccer/design-system: 1.1.0-7

aditya-kumawat added a commit to aditya-kumawat/design-system that referenced this issue Sep 1, 2020
aditya-kumawat added a commit to aditya-kumawat/design-system that referenced this issue Sep 1, 2020
aditya-kumawat added a commit to aditya-kumawat/design-system that referenced this issue Sep 1, 2020
aditya-kumawat added a commit to aditya-kumawat/design-system that referenced this issue Sep 1, 2020
aditya-kumawat added a commit to aditya-kumawat/design-system that referenced this issue Sep 1, 2020
aditya-kumawat added a commit to aditya-kumawat/design-system that referenced this issue Sep 1, 2020
aditya-kumawat added a commit to aditya-kumawat/design-system that referenced this issue Sep 1, 2020
aditya-kumawat added a commit to aditya-kumawat/design-system that referenced this issue Sep 1, 2020
aditya-kumawat added a commit to aditya-kumawat/design-system that referenced this issue Sep 1, 2020
satyamyadav added a commit that referenced this issue Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants