Skip to content

Commit

Permalink
Merge pull request #64 from innovativeinnovation/cho-clean-test
Browse files Browse the repository at this point in the history
  • Loading branch information
williambelle committed Nov 19, 2021
2 parents dbefd02 + e83b47e commit 0c70ef6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
1 change: 0 additions & 1 deletion test/test-email.js
Expand Up @@ -23,7 +23,6 @@ describe('epfl-people-api findByEmail', function () {
});
});

// Sadly...
it('should throw an exception with email taylor.swift@epfl.ch', () => {
const getException = async () => {
await epflPeopleApi.findByEmail('taylor.swift@epfl.ch', 'en');
Expand Down
10 changes: 5 additions & 5 deletions test/test-sciper.js
Expand Up @@ -16,7 +16,7 @@ const epflPeopleApi = require('../src/index.js');
describe('epfl-people-api findBySciper', function () {
this.timeout(10000);

it('should throw an exception with sciper xxx', async () => {
it('should throw an exception with sciper xxx', () => {
const getException = async () => {
await epflPeopleApi.findBySciper('xxx', 'en');
};
Expand All @@ -25,7 +25,7 @@ describe('epfl-people-api findBySciper', function () {
});
});

it('should throw an exception with sciper 69', async () => {
it('should throw an exception with sciper 69', () => {
const getException = async () => {
await epflPeopleApi.findBySciper(69);
};
Expand All @@ -34,7 +34,7 @@ describe('epfl-people-api findBySciper', function () {
});
});

it('should throw an exception with sciper 1000051', async () => {
it('should throw an exception with sciper 1000051', () => {
const getException = async () => {
await epflPeopleApi.findBySciper(1000051, 'en');
};
Expand All @@ -43,7 +43,7 @@ describe('epfl-people-api findBySciper', function () {
});
});

it('should throw an exception with sciper 100000', async () => {
it('should throw an exception with sciper 100000', () => {
const getException = async () => {
await epflPeopleApi.findBySciper(100000, 'en');
};
Expand All @@ -52,7 +52,7 @@ describe('epfl-people-api findBySciper', function () {
});
});

it('should fail with a wrong service url', async () => {
it('should fail with a wrong service url', () => {
const epflPeopleApiMock = rewire('../src/index.js');
epflPeopleApiMock.__set__('SEARCH_URL', 'foobar');

Expand Down

0 comments on commit 0c70ef6

Please sign in to comment.