[iOS + Android] Add max byte size param to write method #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlyprofili
added a commit
to orlyprofili/react-native-ble-manager
that referenced
this pull request
Aug 14, 2023
… but cannot calculate shadow efficiently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working with a BLE device that requires a single message packet of > 20 bytes (23 in my case). I made these changes to allow the default max byte size for messages to be overridden if desired. The default is still
20.Before these changes the
react-native-ble-managerlibrary was incompatible with this device. After these changes, it is now fully compatible.Would greatly appreciate feedback on this. And would hope to have the library support this functionality.