Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heatmap Layer support #76

Closed
JoseGoncalves opened this issue May 25, 2022 · 14 comments · Fixed by #96
Closed

Heatmap Layer support #76

JoseGoncalves opened this issue May 25, 2022 · 14 comments · Fixed by #96
Labels
feature request New feature

Comments

@JoseGoncalves
Copy link
Contributor

Do you have any plans to add a component for the Heatmap Layer?

@HusamElbashir
Copy link
Collaborator

Hey @JoseGoncalves

Can't say I have plans for that at the moment. There are a couple of other issues that I'd like to prioritize when I have some free time.
If someone wants to take a stab at a PR I'll be happy to provide support. Otherwise will look into this when I'm done with the higher priority items on my list.

@HusamElbashir HusamElbashir added the feature request New feature label May 25, 2022
@JoseGoncalves
Copy link
Contributor Author

No TS skills here, so I'll not be capable of doing a PR... I'm going to add that support in JS for my current needs and (eagerly) wait for a proper implementation from your side...

@chemeng
Copy link

chemeng commented Jun 5, 2022

Hi @JoseGoncalves, did you get this working using the package (accessing some underlying component/reference) or through the plain vanilla JS implementation?

@JoseGoncalves
Copy link
Contributor Author

JoseGoncalves commented Jun 6, 2022

Hi @chemeng, still did not hat time to address this... nevertheless, my idea is simply to use the Advanced Usage's third pattern as a base to initialize and use the Google's Heatmap Layer.

@JoseGoncalves
Copy link
Contributor Author

@husamibrahim Any idea when you'll have time to implement this feature?

@HusamElbashir
Copy link
Collaborator

Hello @JoseGoncalves

Apologies for the late response. Things were quite busy at work and in my personal life these last couple of weeks. I'll take a stab at this soon hopefully.

@HusamElbashir
Copy link
Collaborator

Added in v0.14.0. Documentation to be added soon but basic syntax is:

  <GoogleMap
    api-key="API_KEY"
    :libraries="['visualization']"
    style="width: 100%; height: 500px"
    :center="center"
  >
    <HeatmapLayer :options="{ data: heatmapData }" />
  </GoogleMap>

Note that for convenience you can pass an array of plain lat/lng object literals instead of LatLng class instances (you can pass those too or mix object literals with LatLng instances in the data array if you wish).

Let me know if you notice any bugs.

@JoseGoncalves
Copy link
Contributor Author

Hi @husamibrahim. Thanks, I'll test that in the next week.

@JoseGoncalves
Copy link
Contributor Author

Hi @husamibrahim. I've tested this and, while it's working, I get some warnings on the browser console:

Screenshot from 2022-08-30 14-25-10

You can check a demo project were these warnings occur at:

@HusamElbashir
Copy link
Collaborator

Thanks for reporting @JoseGoncalves. Will look into it.
Feel free to create an issue if you wish.

@HusamElbashir
Copy link
Collaborator

Fixed in v0.14.1

@chemeng
Copy link

chemeng commented Oct 11, 2022 via email

@JoseGoncalves
Copy link
Contributor Author

@chemeng This feature is already implemented in the library. Please check #76 (comment)

@chemeng
Copy link

chemeng commented Oct 11, 2022

Yes, thank you, we've started using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants