Document: Further reduce unnecessary HTTP queries when handling attac…

…hments

test/test_client.py

@@ -600,6 +600,32 @@ def data_callback(data):
     s.create('testdb', callback=create_db_callback)
     ioloop.start()
 
+@with_ioloop
+@with_couchdb
+def test_load_inline_attachment_no_fetch(baseurl, ioloop):
+    def create_db_callback(db):
+        db.set(
+            {'testvalue': 'something'},
+            callback=attach_callback,
+            doc_id='testid',
+            attachments={'foobar': (None, 'some textual data')},
+            )
+
+    def attach_callback(doc):
+        def _broken_fetch(*a, **kw):
+            assert False, 'Fetch called when not needed!'
+
+        doc.db._fetch = _broken_fetch
+        doc.load_attachment('foobar', callback=data_callback)
+
+    def data_callback(data):
+        eq(data, 'some textual data')
+        ioloop.stop()
+
+    s = trombi.Server(baseurl, io_loop=ioloop)
+    s.create('testdb', callback=create_db_callback)
+    ioloop.start()
+
 
 @with_ioloop
 @with_couchdb

trombi/client.py

@@ -10,7 +10,7 @@
 # Asynchronous CouchDB client
 import re
 import urllib
-from base64 import b64encode
+from base64 import b64encode, b64decode
 from tornado.httpclient import AsyncHTTPClient
 try:
     import json
@@ -341,10 +341,13 @@ def load_attachment(self, name, callback):
         def _really_callback(response):
             callback(response.body)
 
-        self.db._fetch(
-            '%s/%s' % (self.id, name),
-            _really_callback,
-            )
+        if hasattr(self, 'attachments') and name in self.attachments:
+            callback(b64decode(self.attachments[name]['data']))
+        else:
+            self.db._fetch(
+                '%s/%s' % (self.id, name),
+                _really_callback,
+                )
 
     def delete_attachment(self, name, callback):
         def _really_callback(response):