Always read multiple bits from the current byte #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inolen
reviewed
Nov 5, 2016
| var read = Math.min(toRead, 8 - bitOffset); | ||
|
|
||
| // create a mask with the correct bit width | ||
| var mask = 0xFF >> (8 - read); |
There was a problem hiding this comment.
I think it's a bit more common to see (1 << read) - 1 for this purpose.
| value |= (this._getBit(offset) << i); | ||
| read = 1; | ||
| } | ||
| var toRead = bits - i; |
There was a problem hiding this comment.
var remaining would avoid the confusion with the subsequent read variable name.
icewind1991
force-pushed
the
read-multiple-bits
branch
from
377d259
to
438ee50
Compare
|
fixed both nitpicks Not sure about |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the maximum number of bits from the current byte as we can instead of reading bits one by one.
Note that the check for the special case (reading a whole byte) is more expensive than the overhead for the generic case in my tests