-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VDA5050] Fix Stitch Orders and Schema Typos #42
[VDA5050] Fix Stitch Orders and Schema Typos #42
Conversation
…e it doesn't seem to be working correctly.
…ess next edge timer kicks off at the same time as the navigation callback causing a double navigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bobbleballs, and apologies for the late response.
The PR LGTM, I just made a clarification on the protocol version we target.
I was able to verify that your PR fixes the stitching issue. Have you try sending a stitch order with actions on the stitching node? I think I have spotted a bug which duplicates the action states (I will fix it soon).
Co-authored-by: Leandro <leandropineda.lp@gmail.com>
@leandropineda thanks! |
PR to fix the issue described in #40
Also added a test to verify the Stitch behaviour and enabled the test_vda5050_controller.py tests in the CMakeLists.txt file (Is there any reason why this wasn't enabled? The others aren't added but probably should be?)
This also fixes some typos that I've noticed in the schema whilst I was testing the controller with openTCS's implementation of VDA5050 found here
One thing I have noticed and will open a separate issue for is that some of the schemas are blending between VDA5050 V1.1 and VDA5050 V2.0. What is the version that this controller is targeting?