Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDA5050] Fix Stitch Orders and Schema Typos #42

Merged

Conversation

bobbleballs
Copy link
Contributor

PR to fix the issue described in #40
Also added a test to verify the Stitch behaviour and enabled the test_vda5050_controller.py tests in the CMakeLists.txt file (Is there any reason why this wasn't enabled? The others aren't added but probably should be?)

This also fixes some typos that I've noticed in the schema whilst I was testing the controller with openTCS's implementation of VDA5050 found here

One thing I have noticed and will open a separate issue for is that some of the schemas are blending between VDA5050 V1.1 and VDA5050 V2.0. What is the version that this controller is targeting?

Copy link
Member

@leandropineda leandropineda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bobbleballs, and apologies for the late response.

The PR LGTM, I just made a clarification on the protocol version we target.

I was able to verify that your PR fixes the stitching issue. Have you try sending a stitch order with actions on the stitching node? I think I have spotted a bug which duplicates the action states (I will fix it soon).

Co-authored-by: Leandro <leandropineda.lp@gmail.com>
@bobbleballs
Copy link
Contributor Author

@leandropineda thanks!
Yeah, I've successfully been running this with actions on the stitch updates, however I have noticed the action duplication bug, it hasn't really been an issue for me.
Re: the VDA5050 version I think the only blocker was with the "informations" field as mentioned in #43: I didn't fix this as I wasn't sure what you were targeting.

@leandropineda leandropineda merged commit dcd4e2f into inorbit-ai:humble-devel Aug 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants