Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube): add support version v19.02.39 #1929

Closed
5 tasks done
inotia00 opened this issue Jan 20, 2024 · 5 comments
Closed
5 tasks done

feat(YouTube): add support version v19.02.39 #1929

inotia00 opened this issue Jan 20, 2024 · 5 comments
Labels
Feature request Requesting a new feature

Comments

@inotia00
Copy link
Owner

inotia00 commented Jan 20, 2024

Application

YouTube

Feature description

※ This is said to be written to explain the new patch that will be added to the next build, not Feature request.

I previously declared that the final version with RVX support will be YouTube v18.45.43.

The reasons for this are as follows:

  1. Every time a new YouTube build is released, new bugs are being added, and it appears that Google has no plans to fix these bugs.
  2. Even though a new YouTube build was released, I wasn't able to experience the newly added features.
  3. Since YouTube v18.46.xx+ the RYD patch started to break and needed refactoring.

The reason why I changed my thinking is as follows:

  1. Some YouTube bugs could be resolved with RVX patches.
    : A representative example is the Change player flyout panel toggles patch.
  2. The YouTube bug typing a comment freezes the app and keyboard that existed in YouTube v18.06.41 ~ YouTube v18.49.37 was also fixed in YouTube v19.02.39.
  3. The YouTube bug 'Turn off Incognito' button is translated incorrectly that existed in YouTube v18.06.41 ~ YouTube v18.49.37 was also fixed in YouTube v19.02.39.
  4. The RYD patch has been refactored to support all versions from YouTube v18.25.40 to YouTube v19.02.39.
  5. Also, I have been using and testing YouTube v19.02.39 for a week and have not found any critical bugs yet.

For this reason I plan to add support for YouTube v19.02.39 in the final build.

Motivation

  1. There is no reason for RVX to stay at YouTube v18.45.43 anymore.
  2. After extensive testing, YouTube v19.02.39 has fewer bugs.

Acknowledgements

  • This is not a feature request for YouTube.
  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@girshcatt
Copy link

What if after discontination any new ab testing will come to 19.02.39? Reason to do 18.45.43 last supported version is very simple: it is already supported longer than a month and people tested it enough to find all ab tests and bugs

@inotia00
Copy link
Owner Author

Well, if the patch is broken due to A/B tests, you can just use YouTube v18.25.40 ~ YouTube v18.45.43

YouTube v19.02.39 is not the only version supported

YouTube v19.02.39 is simply an addition to the supported versions while maintaining the existing supported versions (YouTube v18.25.40 ~ YouTube v18.45.43)

@AbakNacchan

This comment was marked as off-topic.

@Legitti

This comment was marked as off-topic.

@inotia00
Copy link
Owner Author

reflected in revanced-patches-v2.220.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

4 participants