bug(YouTube/Toolbar components) : Hide trending searches doesn't work

[Aryan-Chauhan]

NOTE : Check all comments for new information.

Type

Cosmetic

Tools used

Revancify

Application

YT v19.16.39

Patches v4.8.0-dev.4

Integrations v1.9.0-dev.3

Bug description

Hide Trending Searches doesn't work if watch history has zero videos.

To make it work, I enabled my watch history, then I watched one video, then disabled watch history. After doing this, Hide Trending Searches immediately starts working perfectly. It has been like this for months.

But this comes with a cost. With 1 video in your watch history, Home Feed suggestions come back for you.

So, it is requested to make Hide Trending Searches work even if user's watch history has zero videos.

Error logs

No logs.

Solution

The functionality of Hide Trending Searches shouldn't depend on the number of videos in user's watch history.

Additional context

No additional context.

Device Environment

Realme 7 Pro running on Android 12 (skin name is Realme UI 3.0).

Acknowledgements

• This issue does not reproduce on unpatched YouTube or YT Music.
• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• I have written the title and contents in English.

[inotia00]

Hide trending search setting hides the search term suggestion contains the Fire icon.

All other search terms are not hidden.

[Aryan-Chauhan]

Hide trending search setting hides the search term suggestion contains the Fire icon.

All other search terms are not hidden.

If I open another issue like Improve Hide Trending Searches to hide all type of trending searches, will you consider it or not interested?

[Aryan-Chauhan]

Just now, I noticed this.
Hide Trending Searches is just hiding the fire icon & not the whole search suggestion. Compare these two screenshots.

BTW, my watch history & search history is disabled, and both have zero items in them.

Same issue on ReVanced's repository : ReVanced/revanced-patches#873

When Hide Trending Searches is disabled:

When Hide Trending Searches is enabled:

So, it is requested to make Hide Trending Searches such that it can hide all type of context-less recommended searches. Of course, when the user types something, recommendations should show (these can be called as contextful searches).

[inotia00]

It makes sense.
It seems that the patch no longer works due to server-side changes.
Hide trending searches setting will be removed in the next release.

[Aryan-Chauhan]

Thanks!

Any chance of making it work in accordance to the new server-side changes?

[inotia00]

When I checked the bytecode, I couldn't make it support the new server-side changes right now.

Hide trending searches setting will be added again when server-side changes are supported in the future.
Until then the Hide trending searches setting will be removed.

[YT-Advanced]

When I checked the bytecode, I couldn't make it support the new server-side changes right now.

Hide trending searches setting will be added again when server-side changes are supported in the future.
Until then the Hide trending searches setting will be removed.

In the past, I have filtered this new "suggestion searches" via "yt_outline_new_search_black_24" drawable inside resources. However, it have some layout problem so I decided to reject this changes

[inotia00]

Removing setting is not a big deal until server-side changes are supported.
Rather, not removing setting that is not working properly causes more confusion to users.

[YT-Advanced]

Additational, trending search setting hides the search suggestion with the Fire icon, not other search suggestion type so I think you should close this issues without removing patch

[YT-Advanced]

Rather, not removing setting that is not working properly causes more confusion to users.

The patch is still worked, it did its jobs (hide searches with Fire icon)

[inotia00]

Additational, trending search setting hides the search suggestion with the Fire icon, not other search suggestion type so I think you should close this issues without removing patch

nah.. refer it

Just now, I noticed this.
Hide Trending Searches is just hiding the fire icon & not the whole search suggestion. Compare these two screenshots.

#1993 (comment)

Hide trending searches setting changes fire icon to search icon instead of hiding it

[YT-Advanced]

Hide trending searches setting changes fire icon to search icon instead of hiding it

Ah got it

[inotia00]

reflected in revanced-patches-4.8.3

[Aryan-Chauhan]

Hide trending searches setting will be added again when server-side changes are supported in the future.
Until then the Hide trending searches setting will be removed.

This means that there is a possibility of this feature returning in the future (if inotia00, anddea, YT-Advanced, ReVanced Team or other devs figures out how to make it work).

I think, for this reason alone, this issue should be kept open.

Keeping the issue open gives the users hope that this Tier-1 feature may return someday.