Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug (YouTube/Hide ads): Hide fullscreen ads doesn't allow opening community post images #2017

Closed
5 tasks done
ILoveOpenSourceApplications opened this issue May 14, 2024 · 8 comments
Labels
A/B test Reproducible only in some users Bug report Something isn't working

Comments

@ILoveOpenSourceApplications

Type

Error at runtime

Tools used

RVX Manager

Application

YouTube v19.16.39

Bug description

Apparently youtube changed the way where if a community post wasn't of square resolution the user had to tap on the image to view the full image. Now instead it opens similar to how a fullscreen ad opens, and thus the patch doesn't allow opening the image to view the entire image.

Error logs

No response

Solution

Probably if they plan to go ahead with this method (which sucks), community posts somehow will have to be whitelisted from the fullscreen ads patch or change the method of viewing the image to how it was.

Hopefully they'll revert back to the old ways and this can be closed without any patch or changes.

Additional context

There's a chance that this is an A/B test and this may be reverted back, but since I noticed it, I decided to report it here.

A similar report:
https://www.reddit.com/r/youtube/comments/199hhwo/change_to_community_post_pictures_mobile/

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label May 14, 2024
@inotia00
Copy link
Owner

Please attach a screenshot of when the image in the community post is normally opened in fullscreen.
I didn't find any difference.

@inotia00 inotia00 added A/B test Reproducible only in some users Waiting on author OP's answer is needed labels May 14, 2024
@ILoveOpenSourceApplications
Copy link
Author

Here.

Screenshots

How the preview looks:
Screenshot_20240514_223324_YouTube

How it opens in incognito:
Screenshot_20240514_223327_YouTube

How it opens when signed in:
Screenshot_20240514_223341_YouTube

@inotia00 inotia00 removed the Waiting on author OP's answer is needed label May 14, 2024
@ILoveOpenSourceApplications
Copy link
Author

An update: Mine reverted back to the old one. So it's definitely A/B testing. Hopefully it stays that way.

@inotia00
Copy link
Owner

Some people may still be having issues with these A/B tests, so I'll keep this issue open.

Like the issue #1820, I will close the issue once enough time has passed.

@inotia00
Copy link
Owner

inotia00 commented Jun 10, 2024

This issue is still reproduced to some users.

Therefore, I try to solve this issue by adding Close fullscreen ads setting.

  1. If the Close fullscreen ads setting is turned on
    : Click the Close button to close the fullscreen ads.
    Fullscreen ad are exposed for about 0.5 seconds, but there is no side effect because it is closed only when the fullscreen ads are detected.

  2. If the Close fullscreen ads setting is turned off
    : The same method is used as before.
    Always block the dialog without checking the fullscreen dialog in detail.
    There is also a side effect that the community post image on the fullscreen is also blocked. (A/B testing)

inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Jun 10, 2024
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Jun 10, 2024
@ILoveOpenSourceApplications
Copy link
Author

ILoveOpenSourceApplications commented Jun 10, 2024

YouTube briefly displayed the new layout for opening images in community posts, but then switched back to the old one when I reopened the app. So yeah, they're still testing it and haven't come to a conclusion yet.

@inotia00
Copy link
Owner

reflected in revanced-patches-4.9.1-dev.1

@inotia00 inotia00 added Partially resolved Fixed in certain versions and removed Partially resolved Fixed in certain versions labels Jun 10, 2024
@inotia00
Copy link
Owner

inotia00 commented Jun 12, 2024

reflected in revanced-patches-4.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A/B test Reproducible only in some users Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants