Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Spoof Client): Wrong listed spoofing side effects #2072

Closed
5 tasks done
n1cKz1 opened this issue May 26, 2024 · 4 comments
Closed
5 tasks done

bug(YouTube - Spoof Client): Wrong listed spoofing side effects #2072

n1cKz1 opened this issue May 26, 2024 · 4 comments
Labels
Bug report Something isn't working

Comments

@n1cKz1
Copy link

n1cKz1 commented May 26, 2024

Type

Other

Tools used

RVX Manager

Application

YouTube (general)

Bug description

The following changes should be made on spoof client strings:

Watch history on brand accounts doesn't work only on iOS spoof, works fine on VR spoof. It should be removed from "revanced_spoof_client_summary_on" and instead added to "revanced_spoof_client_use_ios_summary_on".

"Higher video qualities may be missing." on iOS spoof has already been fixed. Only HDR quality isn't available, and that's already listed on general spoof summary.

Video background playback works on live streams, only audio-only background playback doesn't (when you tap headphone icon on pip mode). Also, live streams don't work at all on Android 8.0 and probably below, so something like "Live streams may not play on older devices" should probably be added. (iOS spoof)

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@n1cKz1 n1cKz1 added the Bug report Something isn't working label May 26, 2024
@inotia00
Copy link
Owner

Watch history on brand accounts doesn't work only on iOS spoof, works fine on VR spoof. It should be removed from "revanced_spoof_client_summary_on" and instead added to "revanced_spoof_client_use_ios_summary_on".

Even if you spoof it with Android VR, Shorts and Clips use the iOS client.
(i.e. Watch history does not work in Shorts and Clips for both Android VR and iOS clients)

"Higher video qualities may be missing." on iOS spoof has already been fixed.

This depends on your Android version.
Spoofing with the iOS client causes it to use the Android device's media player rather than ExoPlayer.
Certain Android versions support all resolutions, while certain Android versions do not.

@n1cKz1
Copy link
Author

n1cKz1 commented May 26, 2024

Shorts and Clips use the iOS client.

I forgot about that, though it can still be made a little clearer

This depends on your Android version.

Might wanna add "depending on Android version" to avoid confusion, as for most people higher qualities will most likely be available

@inotia00
Copy link
Owner

Might wanna add "depending on Android version" to avoid confusion, as for most people higher qualities will most likely be available

Well, I think the sentence 'Higher quality may be missing' is enough.

Video background playback works on live streams, only audio-only background playback doesn't

This part needs to be changed.

live streams don't work at all on Android 8.0 and probably below, so something like "Live streams may not play on older devices" should probably be added.

This is an issue only for Android 8.0 (API 26)
(The minimum Android version supported by YouTube is Android 8.0)

exoplayer

https://developer.android.com/media/media3/exoplayer/supported-formats#progressive-container

inotia00 added a commit to inotia00/revanced-patches that referenced this issue May 26, 2024
@inotia00
Copy link
Owner

inotia00 commented May 27, 2024

reflected in revanced-patches-4.8.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants