Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube/Shorts components): If the Hide disabled comments button setting is turned on, the comment button is always hidden #2127

Closed
5 tasks done
AykhanUV opened this issue Jun 10, 2024 · 3 comments
Labels
Bug report Something isn't working

Comments

@AykhanUV
Copy link

Type

Other

Tools used

RVX Manager

Application

Latets patches using version 19.20.35

Bug description

In youtube shorts there is no comment button i goto settings and turn it on/off still not there

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

Hyper os 1.0.9 device name is poco x6 pro

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@AykhanUV AykhanUV added the Bug report Something isn't working label Jun 10, 2024
@inotia00 inotia00 changed the title Shorts comments bug: feat(YouTube/Shorts components): If the Hide disabled comments button setting is turned on, the comment button is always hidden Jun 11, 2024
@inotia00
Copy link
Owner

This is a reproducible issue in my side

When I checked the code, the patch uses regular expressions in the byte buffer, so it makes it difficult to find a solution in my side

I will temporarily remove the Hide disabled comments button setting from the next release

@Aryan-Chauhan
Copy link

For some reason, this setting is working fine for me on anddea patches.

@inotia00
Copy link
Owner

reflected in revanced-patches-4.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants