bug(YouTube/Custom branding icon YouTube): Custom header is not applied when both the patch options App icon and Custom header are set custom values

[GucekPL]

Type

Error at runtime

Tools used

RVX Manager

Application

patches 4.9.1-dev.1, YT lastest supported

Bug description

I declared in Manager folder with all files needed for this option, and when I installed app, nothing changed - there's still default and Premium

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

• This issue does not reproduce on unpatched YouTube or YT Music.
• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• I have written the title and contents in English.

[inotia00]

I tried a while ago, but it was changed as intended
Can you attach a screenshot that includes Patch options?

[GucekPL]

[inotia00]

You have to turn on Change header option first to use a custom header
(yeah, Custom branding icon YouTube patch is a bit complicated)

Turn on the Change header option and test if the issue is reproduced

[GucekPL]

Still no changes in the header, still custom heading don't work

[inotia00]

All four images must be located in all directory
Like this:

drawable-hdpi
  L yt_premium_wordmark_header_dark.png
  L yt_premium_wordmark_header_light.png
  L yt_wordmark_header_dark.png
  L yt_wordmark_header_light.png
drawable-mdpi
  L yt_premium_wordmark_header_dark.png
  L yt_premium_wordmark_header_light.png
  L yt_wordmark_header_dark.png
  L yt_wordmark_header_light.png
drawable-xhdpi
  L yt_premium_wordmark_header_dark.png
  L yt_premium_wordmark_header_light.png
  L yt_wordmark_header_dark.png
  L yt_wordmark_header_light.png
drawable-xxhdpi
  L yt_premium_wordmark_header_dark.png
  L yt_premium_wordmark_header_light.png
  L yt_wordmark_header_dark.png
  L yt_wordmark_header_light.png
drawable-xxxhdpi
  L yt_premium_wordmark_header_dark.png
  L yt_premium_wordmark_header_light.png
  L yt_wordmark_header_dark.png
  L yt_wordmark_header_light.png

According to the screenshot you attached, there are only 4 images in the directory drawable-xxhdpi, and only 2 images in the rest of the directory

[GucekPL]

Facticially, I am already setting about correcting this. I'll let you know when I've got it all figured out

[GucekPL]

Custom header changes graphic separately to default and Premium logos, or for all?

[inotia00]

for all

[GucekPL]

Still don't work, I checked files names, I have 4 files (2 to default, 2 to Premium) in all 5 folders

[inotia00]

In the case of the app icon, did it change as intended?

The reason I ask this is because it may be an issue related with the storage permission of RVX Manager

[GucekPL]

Yes, icon was changed (I'm using default, but in black version), but header didn't

[inotia00]

Yes, icon was changed

Ah, that seems to be the cause

[inotia00]

I tested it a little while ago and it seems that the value of Custom header is ignored when both the patch options App icon and Custom header are set custom values:

Set App icon value in preset,
Set Custom header value to custom value
→ Issue not reproduced

Set App icon value to the custom value,
Set Custom header value to custom value
→ Issue reproduced

Thank you for testing and reporting back

I'll fix it in the next release

[GucekPL]

4.9.1-dev.2 - all works properly, custom header works perfectly in YT ;) - I will check later YTM

[inotia00]

reflected in revanced-patches-4.9.1