Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: YouTube crashes when entering revanced extended settings #364

Closed
3 tasks done
ayushTNM opened this issue Mar 1, 2023 · 8 comments
Closed
3 tasks done

bug: YouTube crashes when entering revanced extended settings #364

ayushTNM opened this issue Mar 1, 2023 · 8 comments
Labels
Bug report Something isn't working

Comments

@ayushTNM
Copy link

ayushTNM commented Mar 1, 2023

Type

Error at runtime

Application

Tested on YouTube 18.08.34 and 18.08.36 with patches 2.164.10

Bug description

Opened revanced extended settings after installing patches using revancify

Steps to reproduce

Usual patch
Open YouTube
Open revanced extended settings

Relevant log output

--------- beginning of crash
03-01 09:47:00.022 E/AndroidRuntime(18332): FATAL EXCEPTION: main
03-01 09:47:00.022 E/AndroidRuntime(18332): Process: app.rvx.android.youtube, PID: 18332
03-01 09:47:00.022 E/AndroidRuntime(18332): java.lang.IncompatibleClassChangeError: Found interface app.revanced.integrations.utils.LogHelper$LogMessage, but class was expected (declaration of 'app.revanced.integrations.utils.LogHelper$LogMessage' appears in /data/app/~~sLZIPfEacOydungWCtUSzg==/app.rvx.android.youtube-W0asbTgNr6x5f9FQcpT1vw==/base.apk!classes7.dex)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at app.revanced.integrations.utils.LogHelper$LogMessage.-$$Nest$mfindOuterClassSimpleName(LogHelper.java:1)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at app.revanced.integrations.utils.LogHelper.printException(LogHelper.java:3)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at app.revanced.integrations.settingsmenu.ReVancedSettingsFragment.onCreate(ReVancedSettingsFragment.java:150)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.Fragment.performCreate(Fragment.java:2486)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.FragmentManagerImpl.moveToState(FragmentManager.java:1261)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.FragmentManagerImpl.addAddedFragments(FragmentManager.java:2431)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2210)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2166)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2067)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.FragmentManagerImpl.dispatchMoveToState(FragmentManager.java:3057)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.FragmentManagerImpl.dispatchActivityCreated(FragmentManager.java:3004)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.FragmentController.dispatchActivityCreated(FragmentController.java:185)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.Activity.performCreate(Activity.java:8313)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.Activity.performCreate(Activity.java:8284)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1417)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3626)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3782)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2307)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.os.Handler.dispatchMessage(Handler.java:106)
03-01 09:47:00.022 E/AndroidRuntime(18332): 	at android.os.Looper.loopOnce(Looper.java:201)
03-01 09:47:00.022 E/AndroidRuntime(18332):

Screenshots or videos

screen-20230301-095715.2.mp4

Solution

No response

Additional context

First time logging, so might be wrong

Device Environment

Android 13 stock

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@ayushTNM ayushTNM added the Bug report Something isn't working label Mar 1, 2023
@inotia00
Copy link
Owner

inotia00 commented Mar 1, 2023

I need a list of patches that you include or exclude

Please attach a screenshot of the patch selection screen in Revancify

Also, it is recommended to include all patches until the issue is resolved.

@ayushTNM
Copy link
Author

ayushTNM commented Mar 1, 2023

Screenshot_20230301-114008.png

Screenshot_20230301-114056.png

Should I include all patches or revancify's recommended?

It does work after including all patches

@ILoveOpenSourceApplications

Tested on YouTube 18.08.34 and 18.08.36 with patches 2.164.10

Could it be because these two versions aren't supported and the latest supported version isn't available in apkmirror yet?

@ghost
Copy link

ghost commented Mar 1, 2023

I need a list of patches that you include or exclude

Please attach a screenshot of the patch selection screen in Revancify

Also, it is recommended to include all patches until the issue is resolved.

  "name": "com.google.android.youtube",
  "patches": [
    "default-video-quality",
    "enable-minimized-playback",
    "force-premium-heading",
    "header-switch",
    "hide-button-container",
    "hide-channel-watermark",
    "hide-create-button",
    "hide-email-address",
    "hide-endscreen-cards",
    "hide-flyout-panel",
    "hide-general-ads",
    "hide-info-cards",
    "hide-mix-playlists",
    "hide-pip-notification",
    "hide-shorts-component",
    "hide-snackbar",
    "hide-startup-shorts-player",
    "hide-suggested-actions",
    "hide-tooltip-content",
    "hide-video-ads",
    "microg-support",
    "optimize-resource",
    "overlay-buttons",
    "return-youtube-dislike",
    "settings",
    "sponsorblock",
    "swipe-controls",
    "translations"

@ayushTNM
Copy link
Author

ayushTNM commented Mar 1, 2023

Tested on YouTube 18.08.34 and 18.08.36 with patches 2.164.10

Could it be because these two versions aren't supported and the latest supported version isn't available in apkmirror yet?

Will test when supported version releases.

@ghost
Copy link

ghost commented Mar 1, 2023

YouTube 18.08.34

I have this YouTube version running on 18.08.34 with previous patches.
And with the new ones (v2.164.10) it already gives an error or throws it on the YouTube start page, or ends with a critical error.

@ghost
Copy link

ghost commented Mar 1, 2023

Hmm, I checked version 18.07.34 even lower and now I can say with confidence that three files that were updated today are to blame for this problem:
revanced-integrations-v0.99.10
revanced-patches-v2.164.10
revanced-patches-v2.164.10.json

The situation is the same, when entering the ReVanced Extended, it either throws out or ends with a critical error.

@inotia00
Copy link
Owner

inotia00 commented Mar 1, 2023

fixed in revanced-patches-v2.164.11

@inotia00 inotia00 closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants