Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: patches.compatiblePackages is not iterable #115

Closed
TheRedNet opened this issue Oct 6, 2023 · 8 comments
Closed

TypeError: patches.compatiblePackages is not iterable #115

TheRedNet opened this issue Oct 6, 2023 · 8 comments

Comments

@TheRedNet
Copy link

Describe the bug
Failure after download of dependencies

To Reproduce
Steps to reproduce the behavior:

  1. Change source organization to 'ReVanced'
  2. Click on 'StartPatching'
  3. Wait for dependency download to finish
  4. Click 'Continue'
  5. See error

Screenshots
image

revanced-builder Version: v3.9.15

Desktop (please complete the following information):

  • OS: Windows 11
  • Version: 22H2 (Build 22621.2283)
@ntcong
Copy link

ntcong commented Oct 7, 2023

looks like revanced-patches changed missing patch options from empty array to null which broke patch iteration in several places.

@auanasgheps
Copy link

I have the same issue, let's wait for the maintainer to comment.

@inotia00
Copy link
Owner

inotia00 commented Oct 9, 2023

fixed in rvx-builder-v3.10.0

@inotia00 inotia00 closed this as completed Oct 9, 2023
@auanasgheps
Copy link

As usual, thank you for your fast response!

@auanasgheps
Copy link

Hi, I have updated to builder v3.10 but I'm still getting the error:
image

@inotia00
Copy link
Owner

ah, the reason I closed this issue is because the same issue was reproduced in the RVX patch using CLI v4.0 and I fixed it.
(i.e. I solved the issue in the RVX patch)

Compatibility with official ReVanced sources is not guaranteed

@ntcong
Copy link

ntcong commented Oct 10, 2023

I can confirm it's working for revanced sources, the above comment probably left something not upgraded.

@inotia00
Copy link
Owner

tbh I don't use the official ReVanced source
Since some people seem to want it, I added compatibility with the official ReVanced source in rvx-builder-v3.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants