Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft a selection component #985

Closed
janivo opened this issue Jun 15, 2023 · 1 comment · May be fixed by #1061
Closed

Draft a selection component #985

janivo opened this issue Jun 15, 2023 · 1 comment · May be fixed by #1061
Assignees

Comments

@janivo
Copy link
Collaborator

janivo commented Jun 15, 2023

In preparation for #984, start drafting the selection component without any proper styling. Some things that should be considered:

  • It should be possible to provide a searchable list of hundreds of list items. Therefore, we should keep an eye out for the performance.
    • The items should only be rendered when the popover is opened
    • Is there a way to only render in the viewport currently displayed elements? (e.g. for Angular exists virtual scrolling, here's a native example which implementation seems very extensive)
  • Have a look at our autocomplete component
    • it's quite similar to the selection component besides the input being the host of the popover
    • the library we use in the autocomplete can probably be used in this one as well
    • are there any parts that we can share between the two components? How?
  • Ensure that things like accents are properly handled (e.g.: searching for Jan should also yield Jàn). Have a look at the native localeCompare string method and the sensibility option (also get in touch with me as I've implemented this case just recently)
  • Does a similar library already exist that we can use?
@janivo
Copy link
Collaborator Author

janivo commented Jul 13, 2023

implemented by #1012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants