Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elements|ino-dialog): add new dialogOpen event to prevent rendering issues #1177

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

TobiasHeimGalindo
Copy link
Collaborator

@TobiasHeimGalindo TobiasHeimGalindo commented Jan 17, 2024

Closes #1073

Notes

Introduces the dialogOpen event to ino-dialog for stable rendering of child components that otherwise have misaligned ripples or floating labels. Users will need to listen to this event in the rare case that their content is misaligned or similar.

I didnt add further conditional rendering, e.g. based on a dialigIsOpen state, due to the rarity of this case and it making the ino-dialog default content layout jumpy.

@MariaLStefan
Copy link
Collaborator

I found something which could be used instead of a timeout:

https://github.com/material-components/material-components-web/tree/e58313d/packages/mdc-dialog#javascript-instantiation

If your dialog contains any layout-sensitive components, you should wait until MDCDialog:opened is emitted to instantiate them (or call layout on them) so that the dialog's transition finishes first.

…ndering (e.g. ino-icon-button) and document usage notes
@TobiasHeimGalindo TobiasHeimGalindo changed the title fix(elements|ino-icon-button): ensure correct ripple alignment refactor(elements|ino-dialog): Emit dialogOpen event to fix time sensitive child component rendering Jan 26, 2024
@TobiasHeimGalindo TobiasHeimGalindo changed the title refactor(elements|ino-dialog): Emit dialogOpen event to fix time sensitive child component rendering refactor(elements|ino-dialog): Emit dialogOpen event Jan 26, 2024
@janivo janivo changed the title refactor(elements|ino-dialog): Emit dialogOpen event feat(elements|ino-dialog): add new dialogOpen event to prevent rendering issues Jan 31, 2024
@janivo janivo merged commit 40c6dfe into master Jan 31, 2024
5 checks passed
@janivo janivo deleted the elements-#1073-ino-icon-button-visual-bug branch January 31, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ino-icon-button: Hover ripple misaligned in ino-dialog-footer
3 participants