Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(landingpage): routing of shared storybook links doesn't work #1183

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

TobiasHeimGalindo
Copy link
Collaborator

Closes #1156

Notes:

Ever since I added the selectedVersion dropdown, the iframe will default to the welcome page (https://elements.inovex.de/version/${selectedVersion}/?path=/story/docs-welcome--page)

to prevent this defaulting on each refresh the correct path is now extracted from the initial URL and constructed in the iFrameUrl useMemo. The useStorybookUrl.ts and useStorybookUrlSyncer.ts were okay

@TobiasHeimGalindo TobiasHeimGalindo changed the title refactor(landingage): extract and construct path for accurate links refactor(landinpage): extract and construct path for accurate links Jan 18, 2024
@TobiasHeimGalindo TobiasHeimGalindo changed the title refactor(landinpage): extract and construct path for accurate links refactor(landinpage): extract and construct url paths for accurate storybook links Jan 18, 2024
@TobiasHeimGalindo TobiasHeimGalindo changed the title refactor(landinpage): extract and construct url paths for accurate storybook links refactor(landingpage): extract and construct url paths for accurate storybook links Jan 18, 2024
@MariaLStefan
Copy link
Collaborator

I still get this error when i want to access a page via url paste. I fixed this in #1131 ...
Did something break, or am I the only one who gets this error?

Error: The provided href (/[lang]/library/en) value is missing query values (lang) to be interpolated properly. Read more: https://nextjs.org/docs/messages/href-interpolation-failed

@TobiasHeimGalindo
Copy link
Collaborator Author

@MariaLStefan as mentioned in the bi-weekly, the href lang error is an on going error in the dev mode not caused by this ticket.

@TobiasHeimGalindo TobiasHeimGalindo changed the title refactor(landingpage): extract and construct url paths for accurate storybook links Draft: refactor(landingpage): extract and construct url paths for accurate storybook links Jan 30, 2024
@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as draft January 30, 2024 13:00
@TobiasHeimGalindo TobiasHeimGalindo changed the title Draft: refactor(landingpage): extract and construct url paths for accurate storybook links refactor(landingpage): extract and construct url paths for accurate storybook links Jan 30, 2024
@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as ready for review January 31, 2024 10:24
@janivo janivo changed the title refactor(landingpage): extract and construct url paths for accurate storybook links fix(landingpage): routing of shared storybook links doesn't work Jan 31, 2024
@janivo janivo merged commit 625228a into master Jan 31, 2024
7 checks passed
@janivo janivo deleted the landingpage-#1156-fix-links-not-working-correctly branch January 31, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook<>Landingpage Links dont work
3 participants