Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elements/ino-tooltip): add disabled property #1251

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

BenPag
Copy link
Collaborator

@BenPag BenPag commented Feb 13, 2024

Closes #1238

Proposed Changes

  • use inner div element for TippyJS

@BenPag BenPag marked this pull request as ready for review February 15, 2024 10:49
@BenPag
Copy link
Collaborator Author

BenPag commented Feb 15, 2024

When erverything looks good, then I revert the changes in the example project

@BenPag BenPag merged commit d41304e into master Feb 15, 2024
4 checks passed
@BenPag BenPag deleted the elements#1238_destry_ino-tootip_correctly branch February 15, 2024 14:32
janivo pushed a commit that referenced this pull request Feb 15, 2024
…#1251)

* wip

* add new disabled prop

* add test case in example app for testing

* revert changes in react example

* format fix

* remove disabled property

* run formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ino-tooltip: Tooltip is not destroyed after it's been dismounted from the DOM
2 participants